Re: [PATCH 5/5] crypto: qat - add support for 420xx devices

[Cabiddu, Giovanni]

Hi Geert,

On Tue, Dec 26, 2023 at 12:31:20PM +0100, Geert Uytterhoeven wrote:
> On Fri, 15 Dec 2023, Jie Wang wrote:
> > --- a/drivers/crypto/intel/qat/Kconfig
> > +++ b/drivers/crypto/intel/qat/Kconfig
> > @@ -59,6 +59,17 @@ config CRYPTO_DEV_QAT_4XXX
> > 	  To compile this as a module, choose M here: the module
> > 	  will be called qat_4xxx.
> > 
> > +config CRYPTO_DEV_QAT_420XX
> > +	tristate "Support for Intel(R) QAT_420XX"
> > +	depends on PCI && (!CPU_BIG_ENDIAN || COMPILE_TEST)
> 
> These dependencies suggest that the QAT_420XX device can be present and
> used on any little-endian system that supports PCIe (arm64, MIPS,
> PowerPC, RISC-V, ...).
> 
> However, [1] says QAT is only present on intel Atom® C5000, P5300, and
> P5700 processors, implying the dependency should rather be
> 
>     depends on PCI && (X86_64 || COMPILE_TEST)
> 
> Which one is correct?
Thanks for spotting this.

For this particular device it should be X86_64.

Plug-in cards devices (e.g. DH895xCC), instead, should stay !CPU_BIG_ENDIAN
as they can be used on any little-endian system.

I'm going to send a patch to change this.

-- 
Giovanni