Re: [PATCH 4.14 00/21] 4.14.335-rc1 review

[Daniel Díaz]

Hello!

On 05/01/24 8:38 a. m., Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.14.335 release.
> There are 21 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sun, 07 Jan 2024 14:38:02 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.335-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

We are seeing build problems on Arm32 and Arm64. On Arm32, for the following configurations:

* clang-17-keystone_defconfig
* clang-17-lkftconfig
* clang-17-mini2440_defconfig
* clang-17-sama5_defconfig
* gcc-8-defconfig
* gcc-8-sama5_defconfig
* gcc-12-defconfig
* gcc-12-lkftconfig
* gcc-12-lkftconfig-debug
* gcc-12-lkftconfig-debug-kmemleak
* gcc-12-lkftconfig-kasan
* gcc-12-lkftconfig-kselftest-kernel
* gcc-12-lkftconfig-kunit
* gcc-12-lkftconfig-libgpiod
* gcc-12-lkftconfig-rcutorture
* gcc-12-sama5_defconfig

Failure looks like this:

-----8<-----
  /builds/linux/drivers/pinctrl/pinctrl-at91-pio4.c: In function 'atmel_pinctrl_probe':
  /builds/linux/drivers/pinctrl/pinctrl-at91-pio4.c:1054:3: error: too many arguments to function 'irq_set_lockdep_class'
     irq_set_lockdep_class(irq, &atmel_lock_key, &atmel_request_key);
     ^~~~~~~~~~~~~~~~~~~~~
  In file included from /builds/linux/include/linux/irq.h:517,
                   from /builds/linux/include/linux/gpio/driver.h:7,
                   from /builds/linux/drivers/pinctrl/pinctrl-at91-pio4.c:18:
  /builds/linux/include/linux/irqdesc.h:250:1: note: declared here
   irq_set_lockdep_class(unsigned int irq, struct lock_class_key *class)
   ^~~~~~~~~~~~~~~~~~~~~
  make[3]: *** [/builds/linux/scripts/Makefile.build:330: drivers/pinctrl/pinctrl-at91-pio4.o] Error 1
----->8-----

Bisection points to:

  commit 6c47537ba008b3affe99360f65592ff5b797818f
  Author: Alexis Lothoré <alexis.lothore@xxxxxxxxxxx>
  Date:   Fri Dec 15 22:34:24 2023 +0100

      pinctrl: at91-pio4: use dedicated lock class for IRQ
      
      [ Upstream commit 14694179e561b5f2f7e56a0f590e2cb49a9cc7ab ]

Reproducer:

  tuxmake --runtime podman --target-arch arm --toolchain clang-17 --kconfig defconfig LLVM_IAS=0

Then on Arm64 with Clang 17:

-----8<-----
  /builds/linux/net/8021q/vlan_core.c:332:39: error: incompatible integer to pointer conversion passing '__be16' (aka 'unsigned short') to parameter of type 'const struct vlan_vi
  d_info *' [-Wint-conversion]
    332 |                 if (!vlan_hw_filter_capable(by_dev, vid_info->proto))
        |                                                     ^~~~~~~~~~~~~~~
  /builds/linux/net/8021q/vlan_core.c:169:38: note: passing argument to parameter 'vid_info' here
    169 |                                      const struct vlan_vid_info *vid_info)
        |                                                                  ^
  /builds/linux/net/8021q/vlan_core.c:344:39: error: incompatible integer to pointer conversion passing '__be16' (aka 'unsigned short') to parameter of type 'const struct vlan_vi
  d_info *' [-Wint-conversion]
    344 |                 if (!vlan_hw_filter_capable(by_dev, vid_info->proto))
        |                                                     ^~~~~~~~~~~~~~~
  /builds/linux/net/8021q/vlan_core.c:169:38: note: passing argument to parameter 'vid_info' here
    169 |                                      const struct vlan_vid_info *vid_info)
        |                                                                  ^
  /builds/linux/net/8021q/vlan_core.c:366:39: error: incompatible integer to pointer conversion passing '__be16' (aka 'unsigned short') to parameter of type 'const struct vlan_vid_info *' [-Wint-conversion]
    366 |                 if (!vlan_hw_filter_capable(by_dev, vid_info->proto))
        |                                                     ^~~~~~~~~~~~~~~
  /builds/linux/net/8021q/vlan_core.c:169:38: note: passing argument to parameter 'vid_info' here
    169 |                                      const struct vlan_vid_info *vid_info)
        |                                                                  ^
  3 errors generated.
  make[3]: *** [/builds/linux/scripts/Makefile.build:329: net/8021q/vlan_core.o] Error 1
----->8-----

Bisection in this case points to:

  commit f33474044777425b3578d4e8b22a003f034ae214
  Author: Liu Jian <liujian56@xxxxxxxxxx>
  Date:   Sat Dec 16 15:52:18 2023 +0800

      net: check vlan filter feature in vlan_vids_add_by_dev() and vlan_vids_del_by_dev()
      
      [ Upstream commit 01a564bab4876007ce35f312e16797dfe40e4823 ]

Reproducer:

  tuxmake --runtime podman --target-arch arm64 --toolchain clang-17 --kconfig defconfig LD=ld.lld LLVM_IAS=0

Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>


Greetings!

Daniel Díaz
daniel.diaz@xxxxxxxxxx