Re: [PATCH] spi: make spi_bus_type const

From: Mark Brown
Date: Fri Jan 05 2024 - 10:45:52 EST


On Fri, Jan 05, 2024 at 04:05:18PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Jan 05, 2024 at 02:55:01PM +0000, Mark Brown wrote:

> > Whatever makes the driver core able to handle this doesn't seem to be in
> > mainline yet - what's the story there?

> Odd, what errors are you seeing when you build? I have had to fix up a
> few subsys_* calls for this type of thing, but I don't see spi_bus_type
> being used in those that I saw in my local tree. Did I miss something
> else?

> Maybe just wait for after 6.8-rc1, it builds properly here locally :)

It's this on an x86 allmodconfig:

/build/stage/linux/sound/soc/rockchip/rk3399_gru_sound.c:471:29: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
471 | .bus_type = &spi_bus_type,
| ^
cc1: all warnings being treated as errors

so not actually a core thing, I have to confess I didn't notice where
the assignment was when I glanced at the errors.

Attachment: signature.asc
Description: PGP signature