Re: [RFC PATCH 4/5] regulator: add 88pm88x regulators driver

[Mark Brown]

On Thu, Dec 28, 2023 at 10:39:13AM +0100, Karel Balej wrote:

> @@ -68,6 +68,21 @@ static struct mfd_cell pm886_devs[] = {
>  		.num_resources = ARRAY_SIZE(pm88x_onkey_resources),
>  		.resources = pm88x_onkey_resources,
>  	},
> +	{
> +		.name = "88pm88x-regulator",
> +		.id = PM88X_REGULATOR_ID_LDO2,
> +		.of_compatible = "marvell,88pm88x-regulator",
> +	},

Why are we adding an of_compatible here?  It's redundant, the MFD split
is a feature of Linux internals not of the hardware, and the existing
88pm8xx MFD doesn't use them.

Attachment: signature.asc
Description: PGP signature