Re: [PATCH] usb: typec: tipd: fix use of device-specific init function

[Heikki Krogerus]

On Thu, Jan 04, 2024 at 06:07:12PM +0100, Javier Carrasco wrote:
> The current implementation supports device-pecific callbacks for the
> init function with a function pointer. The patch that introduced this
> feature did not update one call to the tps25750 init function to turn it
> into a call with the new pointer in the resume function.
> 
> Fixes: d49f90822015 ("usb: typec: tipd: add init and reset functions to tipd_data")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>

This was suggested by Roger, no?

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
>  drivers/usb/typec/tipd/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index a956eb976906..8a7cdfee27a1 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -1495,7 +1495,7 @@ static int __maybe_unused tps6598x_resume(struct device *dev)
>  		return ret;
>  
>  	if (ret == TPS_MODE_PTCH) {
> -		ret = tps25750_init(tps);
> +		ret = tps->data->init(tps);
>  		if (ret)
>  			return ret;
>  	}

thans,

-- 
heikki