Re: [PATCH v7 1/7] serial: Do not hold the port lock when setting rx-during-tx GPIO

From: Lino Sanfilippo
Date: Fri Jan 05 2024 - 05:46:55 EST


On 03.01.24 at 12:10, Ilpo Järvinen wrote:
> On Wed, 3 Jan 2024, Lino Sanfilippo wrote:
>

>> Also with commit c54d48543689 ("serial: stm32: Add support for rs485
>> RX_DURING_TX output GPIO") the SER_RS485_RX_DURING_TX flag is only set if a
>> rx-during-tx GPIO is _not_ available, which is wrong. Fix this, too.
>
> This doesn't explain why it's wrong and I could figure it out myself
> either.
>

Ugh, you are right. I confused some things here. This part of the patch is completely
wrong and the concerning code was correct as it was before. I will correct this patch
for v8.


Thanks,
Lino