Re: [Patch v2 2/2] thunderbolt: Teardown tunnels and reset downstream ports created by boot firmware

From: Mika Westerberg
Date: Fri Jan 05 2024 - 02:08:23 EST


On Thu, Jan 04, 2024 at 07:20:05PM +0530, Sanath S wrote:
>
> On 1/3/2024 10:47 PM, Mika Westerberg wrote:
> > On Wed, Jan 03, 2024 at 07:45:56PM +0530, Sanath S wrote:
> > > On 12/21/2023 3:23 PM, Mika Westerberg wrote:
> > > > On Thu, Dec 21, 2023 at 03:01:50PM +0530, Sanath S wrote:
> > > > > > Sure. I'll check with these combinations.
> > > > > Can you name any docks that meets these requirements ? I'll try to get
> > > > > hold of it here and check.
> > > > Pretty much every Titan Ridge based dock. For instance Dell WD19TB.
> > > >
> > > > I have some hardware here that I can use to try it out too.
> > > It seems that issue is seen on Dell WD19TB too. So this fix may have to
> > > extended to TBT3 as well ?
> > Hm, what issue? I thought this works accross all the supported devices
> > due to the DFP, no?
> >
> > > I'll give it a try this week and share the observation.
> Got my hands on Dell WD19TB. And it works!
>
> Here is lspci -t output with and without fix
>
> without fix:
>            +-03.1-[04-62]----00.0-[05-07]--+-02.0-[06]----00.0
>            |                               \-04.0-[07]--
> With fix:
>            +-03.1-[04-62]----00.0-[05-62]--+-02.0-[06]----00.0
>            |                               \-04.0-[07-62]--
>
> I'll send out v3 with with splitting into 2/3 patches(Will see how it looks
> good).

Okay and you checked also that with the WD19TB (and its integrated xHCI)
there are no additional boot delays because of the reset?

> Any other comments, we can take it on v3.

Sure.