Re: [PATCH] PCI/P2PDMA: Fix a sleeping issue in a RCU read section

From: Logan Gunthorpe
Date: Thu Jan 04 2024 - 17:06:36 EST




On 2024-01-04 12:52, Christophe JAILLET wrote:
> It is not allowed to sleep within a RCU read section, so use GFP_ATOMIC
> instead of GFP_KERNEL here.
>
> Fixes: ae21f835a5bd ("PCI/P2PDMA: Finish RCU conversion of pdev->p2pdma")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

This makes sense to me. Though, the use of RCU could probably use a
review. Seeing p2pdma is only released through a devm action on the
pdev, I would think it shouldn't be needed if we hold a reference to the
pdev.

Other than that:

Reviewed-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>

Thanks!

Logan