Re: [PATCH 3/4] platform/x86: wmi: Decouple legacy WMI notify handlers from wmi_block_list

From: Ilpo Järvinen
Date: Thu Jan 04 2024 - 13:14:52 EST


On Wed, 3 Jan 2024, Armin Wolf wrote:

> Until now, legacy WMI notify handler functions where using the
> wmi_block_list, which did no refcounting on the returned WMI device.
> This meant that the WMI device could disappear at any moment,
> potentially leading to various errors.
> Fix this by using bus_find_device() which returns an actual
> reference to the found WMI device.
>
> Tested on a Dell Inspiron 3505 and a Acer Aspire E1-731.
>
> Signed-off-by: Armin Wolf <W_Armin@xxxxxx>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

--
i.