Re: [PATCH] android: removed asm-generic/errno-base.h

[Joel Fernandes]

On 1/4/2024 10:36 AM, Christophe JAILLET wrote:
> Le 26/12/2023 à 18:09, Tanzir Hasan a écrit :
>> asm-generic/errno-base.h can be replaced by linux/errno.h and the file
>> will still build correctly. It is an asm-generic file which should be
>> avoided if possible.
>>
>> Suggested-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
>> Signed-off-by: Tanzir Hasan <tanzirh@xxxxxxxxxx>
>> ---
>>   drivers/android/binderfs.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
>> index 1224ab7aa070..d04ff6029480 100644
>> --- a/drivers/android/binderfs.c
>> +++ b/drivers/android/binderfs.c
>> @@ -29,7 +29,7 @@
>>   #include <linux/uaccess.h>
>>   #include <linux/user_namespace.h>
>>   #include <linux/xarray.h>
>> -#include <uapi/asm-generic/errno-base.h>
>> +#include <linux/errno.h>
> 
> linux/errno.h is already included a few lines above.
> 

Good point! With that nit addressed:
Reviewed-by: Joel Fernandes (Google) <joel@xxxxxxxxxxxxxxxxx>

Thanks.