Re: [RFC 7/9] dt-bindings: wireless: ath11k: describe QCA6390

[Krzysztof Kozlowski]

On 04/01/2024 14:01, Bartosz Golaszewski wrote:
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
> index 817f02a8b481..f584c25f4276 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
> @@ -16,6 +16,7 @@ description: |
>  properties:
>    compatible:
>      enum:
> +      - pci17cb,1101  # QCA6390
>        - pci17cb,1103  # WCN6855
>  
>    reg:
> @@ -27,6 +28,19 @@ properties:
>        string to uniquely identify variant of the calibration data for designs
>        with colliding bus and device ids
>  
> +  enable-gpios:
> +    description: GPIO line enabling the ATH11K module when asserted.
> +    maxItems: 1
> +
> +  vddpmu-supply:
> +    description: VDD_PMU supply regulator handle
> +
> +  vddpcie1-supply:
> +    description: VDD_PCIE1 supply regulator handle
> +
> +  vddpcie2-supply:
> +    description: VDD_PCIE2 supply regulator handle

Looks like these are valid only for specific variant, so you should have
allOf:if:then disallowing other properties when not applicable. The same
applies for existing properties which might not exist on qca6390.

Best regards,
Krzysztof