Re: [PATCH] kunit: Protect string comparisons against NULL

[Richard Fitzgerald]

On 22/12/23 08:39, David Gow wrote:
> On Wed, 20 Dec 2023 at 23:52, Richard Fitzgerald
> <rf@xxxxxxxxxxxxxxxxxxxxx> wrote:
> > Add NULL checks to KUNIT_BINARY_STR_ASSERTION() so that it will fail
> > cleanly if either pointer is NULL, instead of causing a NULL pointer
> > dereference in the strcmp().
> >
> > A test failure could be that a string is unexpectedly NULL. This could
> > be trapped by KUNIT_ASSERT_NOT_NULL() but that would terminate the test
> > at that point. It's preferable that the KUNIT_EXPECT_STR*() macros can
> > handle NULL pointers as a failure.
> >
> > Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>
> > ---
>
> I think this is the right thing to do. There's possibly an argument
> that this should succeed if both are NULL, but I prefer it this way.

Maybe an _OR_NULL() variant of the string test macros would be better to
be explicit that NULL is acceptable.

> Reviewed-by: David Gow <davidgow@xxxxxxxxxx>
>
> Cheers,
> -- David