Re: [PATCH 2/5] arm64: dts: add description for solidrun am642 som and evaluation board

[Krzysztof Kozlowski]

On 04/01/2024 12:01, Josua Mayer wrote:


>>> +
>>> +	leds {
>>> +		compatible = "gpio-leds";
>>> +		pinctrl-names = "default";
>>> +		pinctrl-0 = <&leds_pins_default>;
>>> +		status = "okay";
>> Where was it disabled?
> Nowhere. Better to omit status on new nodes added by new dts file?

Yes, you should not have any redundant status properties. okay is by
default.

>>> +
>>> +		/* D24 */
>>> +		led1: led-1 {
>>> +			label = "led1:green";
>> Use function
> This board has no default function defined by labels or enclosure.
> Not sure what to pick for "function" property. Can I omit it and set only color?
> 
> If so - should I drop label completely - or keep the "led1"  part?

Then keep label.



Best regards,
Krzysztof