Re: [PATCH] dt-bindings: thermal: k3-j72xx: Update bindings for J721S2 SoCs

[Krzysztof Kozlowski]

On 28/12/2023 07:39, Manorit Chawdhry wrote:
> The clock and processor ID for J721S2 differs from the existing
> compatibles, add a new compatible to represent this change for adding
> support for Adaptive voltage scaling.

Subject: everything is "update". Write proper subjects.

A nit, subject: drop second/last, redundant "bindings for". The
"dt-bindings" prefix is already stating that these are bindings.



> 
> Signed-off-by: Manorit Chawdhry <m-chawdhry@xxxxxx>
> ---
>  .../devicetree/bindings/thermal/ti,j72xx-thermal.yaml        | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> index 171b3622ed84..5792ccc058aa 100644
> --- a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> @@ -24,9 +24,13 @@ description: |
>  
>  properties:
>    compatible:
> -    enum:
> -      - ti,j721e-vtm
> -      - ti,j7200-vtm
> +    anyOf:

? Eh, what?

> +      - items:
> +          - enum:
> +              - ti,j721e-vtm
> +              - ti,j7200-vtm
> +              - ti,j721s2-vtm
> +      - maxItems: 2

What? I really do not understand what are you doing here.


>  
>    reg:
>      items:
> @@ -72,7 +76,7 @@ examples:
>    - |
>      #include <dt-bindings/soc/ti,sci_pm_domain.h>
>      wkup_vtm0: thermal-sensor@42040000 {
> -        compatible = "ti,j721e-vtm";
> +        compatible = "ti,j721e-vtm", "ti,j7200-vtm";

It's an enum, not a list.

NAK, please read example-schema and other bindings. Then get review from
TI folks before posting new versions.

Best regards,
Krzysztof