Re: [RFC PATCH 3/5] dt-bindings: regulator: add documentation entry for 88pm88x-regulator

From: Krzysztof Kozlowski
Date: Thu Jan 04 2024 - 04:26:24 EST


On 04/01/2024 10:25, Krzysztof Kozlowski wrote:
> On 28/12/2023 10:39, Karel Balej wrote:
>> From: Karel Balej <balejk@xxxxxxxxx>
>>
>
> A nit, subject: drop second/last, redundant "documentation entry". The
> "dt-bindings" prefix is already stating that these are bindings.
>
>> The Marvell 88PM88X PMICs provide regulators among other things.
>> Document how to use them.
>
>
> You did not document them in the bindings. You just added example to
> make it complete. Where is the binding change?
>
> What's more, I have doubts that you tested it.

I found your other patchset - now I am 100% sure you did not test it.

Best regards,
Krzysztof