Re: [PATCH v4 02/11] dt-bindings: marvell: a38x: convert the soc compatibles description to yaml

From: Krzysztof Kozlowski
Date: Thu Jan 04 2024 - 03:40:02 EST


On 30/12/2023 16:44, Josua Mayer wrote:
> Convert the existing txt binding for armada-38x socs to DT schema
> format.
>

Where is the conversion? I don't see. Conversion means "remove and add"
in a diff. I see only second part.

> Note that the current bindings only document the SoC (armada380,
> armada385, armada388). This is undesirable, instead there should be
> entries for actual boards.
>
> For now only convert to yaml, the content can be corrected separately.
>
> Signed-off-by: Josua Mayer <josua@xxxxxxxxxxxxx>
> ---
> .../bindings/arm/marvell/armada-38x.yaml | 33 ++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
> new file mode 100644
> index 000000000000..5af222e6db18
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
> @@ -0,0 +1,33 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell Armada 38x Platforms
> +
> +maintainers:
> + - Gregory CLEMENT <gregory.clement@xxxxxxxxxxx>
> +
> +properties:
> + $nodename:
> + const: '/'
> + compatible:
> + oneOf:
> +
> + - description: Armada 380 SoC
> + items:
> + - const: marvell,armada380
> +
> + - description: Armada 385 SoC
> + items:
> + - const: marvell,armada385
> + - const: marvell,armada380
> +

No, we have been here.

NAK.

Best regards,
Krzysztof