Re: [PATCH v5 02/12] clk: qcom: Use qcom_branch_set_clk_en()

From: Johan Hovold
Date: Thu Jan 04 2024 - 03:30:35 EST


On Wed, Jan 03, 2024 at 02:36:00PM +0100, Konrad Dybcio wrote:
> Instead of magically poking at the bit0 of branch clocks' CBCR, use
> the newly introduced helper.
>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
> drivers/clk/qcom/camcc-sc8280xp.c | 6 ++----

> drivers/clk/qcom/dispcc-sc8280xp.c | 4 ++--

> drivers/clk/qcom/gcc-sc8280xp.c | 25 ++++++++++---------------

> drivers/clk/qcom/gpucc-sc8280xp.c | 9 +++------

I only reviewed the sc8280xp ones, and with the updated comment this
looks good to me now:

Reviewed-by: Johan Hovold <johan+linaro@xxxxxxxxxx>

Johan