Re: [PATCH 1/2] dt-bindings: cpufreq: Add big CPU supply

From: Krzysztof Kozlowski
Date: Thu Jan 04 2024 - 03:04:09 EST


On 29/12/2023 22:28, Nícolas F. R. A. Prado wrote:
> The performance-controller hardware block on MediaTek SoCs is
> responsible for controlling the frequency of the CPUs. As such, it needs
> any CPU regulator to have been configured prior to initializing. Add a
> phandle in the binding so this dependency can be described.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
> ---
>
> .../devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
> index d0aecde2b89b..d75b01d04998 100644
> --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
> @@ -33,6 +33,8 @@ properties:
> performance domains.
> const: 1
>
> + big-cpus-supply: true

Why big? Neither little nor medium need power? Why you do not need to
provide all supplies?

About the naming, use something matching the devices, e.g. from their
datasheet/manual.

Best regards,
Krzysztof