Re: [PATCH net-next v1] net: mctp: use deprecated parser in mctp_set_link_af

From: Lin Ma
Date: Thu Jan 04 2024 - 02:05:29 EST

Next message: Yang, Weijiang: "Re: [PATCH v8 00/26] Enable CET Virtualization"
Previous message: Kevin Martin: "Re: [PATCH 1/2] kbuild: Enable decompression for use by EXTRA_FIRMWARE The build system can currently only compress files. This patch adds the functionality to decompress files. Decompression is needed for building firmware files into the kernel if those files are compressed on the filesystem. Compressed firmware files are in use by Gentoo, Fedora, Arch, and others."
In reply to: Jeremy Kerr: "Re: [PATCH net-next v1] net: mctp: use deprecated parser in mctp_set_link_af"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hello Jeremy,

>
> Hi Lin,
>
> > (1) will get AF_MCTP with nla_type(...) call, and (2) will then
> > passing `af` to `mctp_set_link_af`, which will expect the
> > `NLA_F_NESTED` flag.
>
> You could set that flag? It's not exclusive with the attribute type.
> From netlink.h:
>
> /*
> * nla_type (16 bits)
> * +---+---+-------------------------------+
> * | N | O | Attribute Type |
> * +---+---+-------------------------------+
> * N := Carries nested attributes
> * O := Payload stored in network byte order
> *
> * Note: The N and O flag are mutually exclusive.
> */
>
> Which is what we do with existing userspace:
>
> https://github.com/CodeConstruct/mctp/blob/6aa4b052d/src/mctp.c#L569C1-L569C1
>
> Cheers,

Oops, my bad. Just know that the nla_type will mask with `NLA_TYPE_MASK`.

Sorry for the bother. T^T

>
>
> Jeremy

Thanks
Lin