Re: [EXTERNAL] Re: [PATCH v4 1/4] ASoC: dt-bindings: move tas2563 from tas2562.yaml to tas2781.yaml

[Krzysztof Kozlowski]

On 03/01/2024 16:10, Ding, Shenghao wrote:
>>> -  reg:
>>> -    description:
>>> -      I2C address, in multiple tas2781s case, all the i2c address
>>> -      aggregate as one Audio Device to support multiple audio slots.
>>> -    maxItems: 8
>>> -    minItems: 1
>>> -    items:
>>> -      minimum: 0x38
>>> -      maximum: 0x3f
>>> +    description: |
>>> +      ti,tas2563: 6.1-W Boosted Class-D Audio Amplifier With Integrated
>>> +      DSP and IV Sense, 16/20/24/32bit stereo I2S or multichannel TDM.
>>> +
>>> +      ti,tas2781: 24-V Class-D Amplifier with Real Time Integrated Speaker
>>> +      Protection and Audio Processing, 16/20/24/32bit stereo I2S or
>>> +      multichannel TDM.
>>> +    oneOf:
>>> +      - items:
>>> +          - enum:
>>> +              - ti,tas2563
>>> +          - const: ti,tas2781
>>> +      - enum:
>>> +          - ti,tas2781
>>> +
>>> +  reg: true
>>
>> min/maxItems must stay here
>>
>> I already reminded this in v3.
> How to express maxItems is 4 for tas2563 on the same i2c bus(only 4 different i2c addresses) 
> and maxItems is 8 for tas2781 on the same i2c bus (8 different i2c addresses) here.

Here you have only the widest constraints. In allOf:if:then you
customize them.

Best regards,
Krzysztof