Re: [PATCH v4 11/11] mm/mempolicy: extend set_mempolicy2 and mbind2 to support weighted interleave
From: Dan Carpenter
Date: Wed Jan 03 2024 - 06:16:39 EST
Hi Gregory,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Gregory-Price/mm-mempolicy-implement-the-sysfs-based-weighted_interleave-interface/20231219-074837
base: https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools.git perf-tools
patch link: https://lore.kernel.org/r/20231218194631.21667-12-gregory.price%40memverge.com
patch subject: [PATCH v4 11/11] mm/mempolicy: extend set_mempolicy2 and mbind2 to support weighted interleave
config: x86_64-randconfig-161-20231219 (https://download.01.org/0day-ci/archive/20231220/202312200223.7X9rUFgu-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
| Closes: https://lore.kernel.org/r/202312200223.7X9rUFgu-lkp@xxxxxxxxx/
smatch warnings:
mm/mempolicy.c:2044 __do_sys_get_mempolicy2() warn: maybe return -EFAULT instead of the bytes remaining?
mm/mempolicy.c:2044 __do_sys_get_mempolicy2() warn: maybe return -EFAULT instead of the bytes remaining?
vim +2044 mm/mempolicy.c
a2af87404eb73e Gregory Price 2023-12-18 1992 SYSCALL_DEFINE4(get_mempolicy2, struct mpol_args __user *, uargs, size_t, usize,
a2af87404eb73e Gregory Price 2023-12-18 1993 unsigned long, addr, unsigned long, flags)
a2af87404eb73e Gregory Price 2023-12-18 1994 {
a2af87404eb73e Gregory Price 2023-12-18 1995 struct mpol_args kargs;
a2af87404eb73e Gregory Price 2023-12-18 1996 struct mempolicy_args margs;
a2af87404eb73e Gregory Price 2023-12-18 1997 int err;
a2af87404eb73e Gregory Price 2023-12-18 1998 nodemask_t policy_nodemask;
a2af87404eb73e Gregory Price 2023-12-18 1999 unsigned long __user *nodes_ptr;
8bfd7ddc0dd439 Gregory Price 2023-12-18 2000 unsigned char __user *weights_ptr;
8bfd7ddc0dd439 Gregory Price 2023-12-18 2001 unsigned char weights[MAX_NUMNODES];
a2af87404eb73e Gregory Price 2023-12-18 2002
a2af87404eb73e Gregory Price 2023-12-18 2003 if (flags & ~(MPOL_F_ADDR))
a2af87404eb73e Gregory Price 2023-12-18 2004 return -EINVAL;
a2af87404eb73e Gregory Price 2023-12-18 2005
a2af87404eb73e Gregory Price 2023-12-18 2006 /* initialize any memory liable to be copied to userland */
a2af87404eb73e Gregory Price 2023-12-18 2007 memset(&margs, 0, sizeof(margs));
8bfd7ddc0dd439 Gregory Price 2023-12-18 2008 memset(weights, 0, sizeof(weights));
a2af87404eb73e Gregory Price 2023-12-18 2009
a2af87404eb73e Gregory Price 2023-12-18 2010 err = copy_struct_from_user(&kargs, sizeof(kargs), uargs, usize);
a2af87404eb73e Gregory Price 2023-12-18 2011 if (err)
a2af87404eb73e Gregory Price 2023-12-18 2012 return -EINVAL;
a2af87404eb73e Gregory Price 2023-12-18 2013
8bfd7ddc0dd439 Gregory Price 2023-12-18 2014 if (kargs.il_weights)
8bfd7ddc0dd439 Gregory Price 2023-12-18 2015 margs.il_weights = weights;
8bfd7ddc0dd439 Gregory Price 2023-12-18 2016 else
8bfd7ddc0dd439 Gregory Price 2023-12-18 2017 margs.il_weights = NULL;
8bfd7ddc0dd439 Gregory Price 2023-12-18 2018
a2af87404eb73e Gregory Price 2023-12-18 2019 margs.policy_nodes = kargs.pol_nodes ? &policy_nodemask : NULL;
a2af87404eb73e Gregory Price 2023-12-18 2020 if (flags & MPOL_F_ADDR)
a2af87404eb73e Gregory Price 2023-12-18 2021 err = do_get_vma_mempolicy(untagged_addr(addr), NULL, &margs);
a2af87404eb73e Gregory Price 2023-12-18 2022 else
a2af87404eb73e Gregory Price 2023-12-18 2023 err = do_get_task_mempolicy(&margs);
a2af87404eb73e Gregory Price 2023-12-18 2024
a2af87404eb73e Gregory Price 2023-12-18 2025 if (err)
a2af87404eb73e Gregory Price 2023-12-18 2026 return err;
a2af87404eb73e Gregory Price 2023-12-18 2027
a2af87404eb73e Gregory Price 2023-12-18 2028 kargs.mode = margs.mode;
a2af87404eb73e Gregory Price 2023-12-18 2029 kargs.mode_flags = margs.mode_flags;
a2af87404eb73e Gregory Price 2023-12-18 2030 kargs.policy_node = margs.policy_node;
a2af87404eb73e Gregory Price 2023-12-18 2031 kargs.home_node = margs.home_node;
a2af87404eb73e Gregory Price 2023-12-18 2032 if (kargs.pol_nodes) {
a2af87404eb73e Gregory Price 2023-12-18 2033 nodes_ptr = u64_to_user_ptr(kargs.pol_nodes);
a2af87404eb73e Gregory Price 2023-12-18 2034 err = copy_nodes_to_user(nodes_ptr, kargs.pol_maxnodes,
a2af87404eb73e Gregory Price 2023-12-18 2035 margs.policy_nodes);
a2af87404eb73e Gregory Price 2023-12-18 2036 if (err)
a2af87404eb73e Gregory Price 2023-12-18 2037 return err;
This looks wrong as well.
a2af87404eb73e Gregory Price 2023-12-18 2038 }
a2af87404eb73e Gregory Price 2023-12-18 2039
8bfd7ddc0dd439 Gregory Price 2023-12-18 2040 if (kargs.mode == MPOL_WEIGHTED_INTERLEAVE && kargs.il_weights) {
8bfd7ddc0dd439 Gregory Price 2023-12-18 2041 weights_ptr = u64_to_user_ptr(kargs.il_weights);
8bfd7ddc0dd439 Gregory Price 2023-12-18 2042 err = copy_to_user(weights_ptr, weights, kargs.pol_maxnodes);
8bfd7ddc0dd439 Gregory Price 2023-12-18 2043 if (err)
8bfd7ddc0dd439 Gregory Price 2023-12-18 @2044 return err;
This should return -EFAULT same as the copy_to_user() on the next line.
8bfd7ddc0dd439 Gregory Price 2023-12-18 2045 }
8bfd7ddc0dd439 Gregory Price 2023-12-18 2046
a2af87404eb73e Gregory Price 2023-12-18 2047 return copy_to_user(uargs, &kargs, usize) ? -EFAULT : 0;
a2af87404eb73e Gregory Price 2023-12-18 2048 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki