Re: [PATCH] nvmem: fix issue within nvmem_register with fixed-layout.

From: Miquel Raynal
Date: Wed Jan 03 2024 - 03:40:39 EST


Hi Catalin,

miquel.raynal@xxxxxxxxxxx wrote on Tue, 5 Dec 2023 10:05:02 +0100:

> Hi Catalin,
>
> + GKH
> + Luca (who initially reported this issue)
>
> catalin.popescu@xxxxxxxxxxxxxxxxxxxx wrote on Tue, 5 Dec 2023 08:48:27
> +0000:
>
> > Adding more people.
> >
> > On 30.11.23 17:29, Catalin Popescu wrote:
> > > fixed-layout is natively supported by NVMEM framework.
> > > Yet, it's not been declared as a supported layout. As a
> > > result, nvmem_register always returns -EPROBE_DEFER if
> > > configuration has no layout and the NVMEM provider DT
> > > uses a fixed layout.
> > >
> > > As a fix, declare fixed-layout as a supported layout
> > > and use add_cells callback to parse the cells. This adds
> > > consistency over layouts parsing as fixed-layout parsing
> > > is handled in the same way than others nvmem layouts.
>
> I believe this patch (not taken yet) should fix your issue and should be
> queued to fixes.
>
> Link: https://lore.kernel.org/lkml/20231124193814.360552-1-miquel.raynal@xxxxxxxxxxx/
>
> However I like your approach which should probably be taken into
> consideration for the next cycle, as I think it fits Rafal's
> original idea pretty well.

Do you plan on updating this patch at -rc1? I think it would be
interesting to follow your idea.

Thanks,
Miquèl