Re: [PATCH v1] perf stat: Fix hard coded ll miss units

[Liang, Kan]

On 2024-01-02 2:34 p.m., Ian Rogers wrote:
> On Mon, Dec 11, 2023 at 10:13 AM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>>
>> Copy-paste error where LL cache misses are reported as l1i.
>>
>> Suggested-by: Guillaume Endignoux <guillaumee@xxxxxxxxxx>
>> Fixes: 0a57b910807a ("perf stat: Use counts rather than saved_value")
>> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
>

Reviewed-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>

Thanks,
Kan

> Ping. Trivial 1 character fix but no reviews :-(
> 
> Thanks,
> Ian
> 
>> ---
>>  tools/perf/util/stat-shadow.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
>> index 1c5c3eeba4cf..e31426167852 100644
>> --- a/tools/perf/util/stat-shadow.c
>> +++ b/tools/perf/util/stat-shadow.c
>> @@ -264,7 +264,7 @@ static void print_ll_miss(struct perf_stat_config *config,
>>         static const double color_ratios[3] = {20.0, 10.0, 5.0};
>>
>>         print_ratio(config, evsel, aggr_idx, misses, out, STAT_LL_CACHE, color_ratios,
>> -                   "of all L1-icache accesses");
>> +                   "of all LL-cache accesses");
>>  }
>>
>>  static void print_dtlb_miss(struct perf_stat_config *config,
>> --
>> 2.43.0.472.g3155946c3a-goog
>>
>