Re: [PATCH v1] mm: abstract shadow stack vma behind arch_is_shadow_stack_vma
From: Edgecombe, Rick P
Date: Tue Jan 02 2024 - 12:50:34 EST
On Fri, 2023-12-22 at 15:51 -0800, Deepak Gupta wrote:
> +
> +static inline bool arch_is_shadow_stack_vma(vm_flags_t vm_flags)
> +{
> + return (vm_flags & VM_SHADOW_STACK) ? true : false;
> +}
> +
The bit after the "?" should be unneeded. I would think that patterns
like:
bool res = val ? true : false;
...should never be needed for the kernel's current bool typedef. Is
there some special arch define consideration or something, I'm unaware
of?
https://www.kernel.org/doc/html/latest/process/coding-style.html#using-bool