Re: [PATCH 7/8] platform/x86/intel/pmc/lnl: Add GBE LTR ignore during suspend

From: Hans de Goede
Date: Tue Jan 02 2024 - 07:25:15 EST


Hi,

On 12/23/23 04:25, David E. Box wrote:
> Add the GBE LTR ignore suspend time fix for Lunar Lake.
>
> Fixes: 119652b855e6 ("platform/x86/intel/pmc: Add Lunar Lake M support to intel_pmc_core driver")
> Signed-off-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx>

Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans



> ---
> drivers/platform/x86/intel/pmc/lnl.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/x86/intel/pmc/lnl.c b/drivers/platform/x86/intel/pmc/lnl.c
> index fe97ad09a1a6..eb350d64efdf 100644
> --- a/drivers/platform/x86/intel/pmc/lnl.c
> +++ b/drivers/platform/x86/intel/pmc/lnl.c
> @@ -509,6 +509,8 @@ void lnl_d3_fixup(void)
> int lnl_resume(struct pmc_dev *pmcdev)
> {
> lnl_d3_fixup();
> + pmc_core_send_ltr_ignore(pmcdev, 3, 0);
> +
> return pmc_core_resume_common(pmcdev);
> }
>
> @@ -521,6 +523,7 @@ int lnl_core_init(struct pmc_dev *pmcdev)
>
> lnl_d3_fixup();
>
> + pmcdev->suspend = cnl_suspend;
> pmcdev->resume = lnl_resume;
> pmcdev->regmap_list = lnl_pmc_info_list;
> ret = pmc_core_ssram_init(pmcdev, func);