Re: [PATCH] sunrpc: Improve exception handling in krb5_etm_checksum()

From: Markus Elfring
Date: Tue Jan 02 2024 - 04:26:59 EST



> +++ b/net/sunrpc/auth_gss/gss_krb5_crypto.c

> @@ -970,8 +969,7 @@ u32 krb5_etm_checksum(struct crypto_sync_skcipher *cipher,
>
> out_free_ahash:
> ahash_request_free(req);
> -out_free_mem:
> - kfree(iv);
> +out_free_cksumdata:
> kfree_sensitive(checksumdata);
> return err ? GSS_S_FAILURE : GSS_S_COMPLETE;
> }


How do you think about to use the identifier “out_free_checksumdata”?

Regards,
Markus