Re: [PATCH v2 net-next] selftests/net: change shebang to bash to support "source"

[Hangbin Liu]

On Tue, Jan 02, 2024 at 01:51:56PM +0800, Yujie Liu wrote:
> > Looks like it'd be simpler to just replace the "source" commands with
> > "." and leave the shebang as is (unless there are other bash-specific
> > constructs in these scripts of course).
> > 
> > Generally speaking, I think we should avoid madating a specific shell,
> > unless that really simplifies the test script (which is not the case
> > here).
> 
> Hi Guillaume,
> 
> Thanks for the comments. As this is related with a large patch series from
> Hangbin, and other scripts use "source" during the conversion, so we may
> need some input from Hangbin.
> 
> Hi Hangbin,
> 
> Could you please share your comments on this? Would you like to replace
> "source" with "." for these two specific scripts as Guillaume suggested,
> or change the shebang from "sh" to "bash"?

Both works for me :)

Thanks
Hangbin