Re: [PATCH 4/4] netlink: Move an assignment for the variable “cb_mutex” in __netlink_kernel_create()

From: Stephen Hemminger
Date: Mon Jan 01 2024 - 13:51:14 EST


On Sun, 31 Dec 2023 18:48:11 +0100
Markus Elfring <Markus.Elfring@xxxxxx> wrote:

> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sun, 31 Dec 2023 18:16:26 +0100
>
> Move one assignment for the variable “cb_mutex” closer to the place
> where this pointer is used.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>

NAK
Useless code churn, no improvement in performance or readablilty.
Compiler optimizer will do this already if it wants.