Re: [PATCH 1/4] netlink: Improve exception handling in __netlink_kernel_create()

From: Stephen Hemminger
Date: Mon Jan 01 2024 - 13:14:12 EST


On Sun, 31 Dec 2023 18:42:30 +0100
Markus Elfring <Markus.Elfring@xxxxxx> wrote:

> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sun, 31 Dec 2023 17:26:41 +0100
>
> The kfree() function was called in one case by
> the __netlink_kernel_create() function during error handling
> even if the passed variable contained a null pointer.
> This issue was detected by using the Coccinelle software.
>
> Thus use another label.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>


NAK
Please look at something else, calling kfree(NULL) is correct
and the preferred solution.