[PATCH 2/4] netlink: Move an assignment for the variable “sk” in __netlink_kernel_create()

From: Markus Elfring
Date: Sun Dec 31 2023 - 12:44:45 EST


From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 31 Dec 2023 17:36:50 +0100

Move one assignment for the variable “sk” closer to the place
where this pointer is used.

Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---
net/netlink/af_netlink.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index c3f88015cacf..b71d9c21d15b 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -2033,8 +2033,6 @@ __netlink_kernel_create(struct net *net, int unit, struct module *module,
if (__netlink_create(net, sock, cb_mutex, unit, 1) < 0)
goto out_sock_release_nosk;

- sk = sock->sk;
-
if (!cfg || cfg->groups < 32)
groups = 32;
else
@@ -2044,6 +2042,7 @@ __netlink_kernel_create(struct net *net, int unit, struct module *module,
if (!listeners)
goto out_netlink_release_sock;

+ sk = sock->sk;
sk->sk_data_ready = netlink_data_ready;
if (cfg && cfg->input)
nlk_sk(sk)->netlink_rcv = cfg->input;
--
2.43.0