Re: Stack corruption in bch2_nocow_write

From: Daniel J Blueman
Date: Sun Dec 31 2023 - 04:54:36 EST


On Sun, 31 Dec 2023 at 06:41, Kent Overstreet <kent.overstreet@xxxxxxxxx> wrote:
>
> On Fri, Dec 29, 2023 at 07:43:13PM +0800, Daniel J Blueman wrote:
> > Hi Kent et al,
> >
> > On Linux 6.7-rc7 from bcachefs master SHA f3608cbdfd built with UBSAN
> > [1], with a crafted workload [2] I'm able to trigger stack corruption
> > in bch2_nocow_write [3].
> >
> > Let me know if you can't reproduce it and I'll check reproducibility
> > on another platform, and let me know for any patch testing.
>
> Can you give the bcachefs-testing branch a try?

Good fixes! I can't reproduce the issue on SHA 67503f8d4 in
bcachefs.git/bcachefs-testing, and no warnings are triggered with
CONFIG_PROVE_LOCKING.

Tested-by: Daniel J Blueman <daniel@xxxxxxxxx>

Thanks,
Dan
--
Daniel J Blueman