Re: [PATCH 8/8] drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK

[Linus Walleij]

Hi Dario,

On Fri, Dec 29, 2023 at 2:52 PM Dario Binacchi
<dario.binacchi@xxxxxxxxxxxxxxxxxxxx> wrote:

> The initialization commands are taken from the STMicroelectronics driver
> found at https://github.com/STMicroelectronics/STM32CubeF7/blob/master/Drivers/BSP/Components/nt35510/
>
> Signed-off-by: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>

NAK.

Please rewrite the patch to use the detailed instructions with clear definitions
about what is going on the same way as in the old driver, and add #defines
for all the magic commands, and break down the commands to what they
are actually doing with the display hardware.

Magic display init sequences are not OK in this driver, and not in general,
it is all the other drivers that are just unaware about what they are doing
and this driver actually isn't.

Yours,
Linus Walleij