Re: [PATCH V8 1/3] mfd: Add support for UP board CPLD/FPGA

[Jack Chang]

On 2023/12/28 23:31, Krzysztof Kozlowski wrote:
> On 28/12/2023 16:15, larry.lai wrote:
>> The UP Squared board <http://www.upboard.com> implements certain
>> features (pin control, onboard LEDs or CEC) through an on-board CPLD/FPGA.

...

>> +static int upboard_cpld_read(void *context, unsigned int reg, unsigned int *val)
>> +{
>> +	struct upboard_fpga * const fpga = context;
> 
> This const does not make sense. Drop it. Unless you wanted to say
> something else, like struct is not modified, but then please read C
> tutorials. This applies to all your three patches.

will do

-- 
Best Regards,
Jack Chang