Re: [PATCH] thermal: core: export the governor register related API

From: gregkh@xxxxxxxxxxxxxxxxxxx
Date: Fri Dec 29 2023 - 03:46:32 EST


On Fri, Dec 29, 2023 at 12:30:10PM +0800, Di Shen wrote:
> Hi Rafael,
>
> On Fri, Dec 29, 2023 at 4:24 AM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> >
> > On Thu, Dec 28, 2023 at 11:39 AM Di Shen <di.shen@xxxxxxxxxx> wrote:
> > >
> > > To enable users to register their own thermal governor,
> >
> > Why would anyone want to do that?
> >
>
> On Android systems, due to GKI restrictions, vendors cannot modify the
> kernel, and
> vendor-specific changes must be loaded as modules, so export this symbol so that
> vendors can load their own specific governor.

Why not get the needed changes merged upstream properly instead? That's
why Android does not allow you to change the core kernel, they want you
to work upstream first.

Random symbol exports are not allowed without a user for obvious reasons
(and you don't want us to take these patches either.)

thanks,

greg k-h