Re: [PATCH v1 2/2] ASoC: starfive: Add drivers of Cadence Multi-Channel I2S Controller

[Xingyu Wu]

On 2023/12/22 20:39, Mark Brown wrote:
> On Fri, Dec 22, 2023 at 05:11:17PM +0800, Xingyu Wu wrote:
>> On 2023/12/21 20:55, Mark Brown wrote:
>> > On Thu, Dec 21, 2023 at 11:32:23AM +0800, Xingyu Wu wrote:
> 
>> >>  sound/soc/starfive/cdns-jh8100-i2s-pcm.c | 262 ++++++++
>> >>  sound/soc/starfive/cdns-jh8100-i2s.c     | 727 +++++++++++++++++++++++
>> >>  sound/soc/starfive/cdns-jh8100-i2s.h     | 171 ++++++
> 
>> > If this is a Cadence IP why is the entire driver SoC specific?
> 
>> This a new driver about this Cadence I2S controller. Should I create a new folder and file like this:
> 
>> sound/soc/cdns/cdns-i2s*
> 
>> and I use different compatible to support other SoC like JH8100?
> 
> Yes, that seems more what I'd expect - with a fallback compatible for
> things that don't need any special quirks.

Okay, I will modify these in next version.

Thanks,
Xingyu Wu