Re: [PATCH v2 1/5] dt-bindings: crypto: Add Tegra Security Engine

From: Krzysztof Kozlowski
Date: Thu Dec 28 2023 - 05:29:53 EST


On 28/12/2023 10:33, Akhil R wrote:
>>> +properties:
>>> + compatible:
>>> + const: nvidia,tegra234-se4-hash
>>
>> What is se4?
>>
>> Anyway, filename like compatible.
> Similar to the above, the hardware name is SE4.
>
> nvidia,tegra234-se-aes and nvidia,tegra234-se-hash does look good to me. But I am a bit concerned
> about the ABI breakage in case, we need a different compatible for the remaining instance.

Isn't this a new device? What ABI breakage? What would be affected?

Best regards,
Krzysztof