Re: [PATCH v4 2/6] mm/zswap: reuse dstmem when decompress

From: Herbert Xu
Date: Thu Dec 28 2023 - 04:49:45 EST


On Thu, Dec 28, 2023 at 09:03:32PM +1300, Barry Song wrote:
>
> for CPU-based alg, we have completed the compr/decompr within
> crypto_acomp_decompress()
> synchronously. they won't return EINPROGRESS, EBUSY.
>
> The problem is that crypto_acomp won't expose this information to its
> users. if it does,
> we can use this info, we will totally avoid the code of copying
> zsmalloc's data to a tmp
> buffer for the most majority users of zswap.
>
> But I am not sure if we can find a way to convince Herbert(+To) :-)

What would you like to expose? The async status of the underlying
algorithm?

We could certainly do that. But I wonder if it might actually be
better for you to allocate a second sync-only algorithm for such
cases. I'd like to see some real numbers.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt