Re: [PATCH v4 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs

[Krzysztof Kozlowski]

On 28/12/2023 07:08, James Tai wrote:
> Add the YAML documentation for Realtek DHC (Digital Home Center) SoCs.
> 
> Signed-off-by: James Tai <james.tai@xxxxxxxxxxx>

Thank you for your patch. There is something to discuss/improve.

> +  interrupts:
> +    minItems: 1
> +    maxItems: 3
> +    description:
> +      Contains the GIC SPI IRQs mapped to the external interrupt lines.
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupt-controller
> +  - '#interrupt-cells'
> +  - '#address-cells'
> +  - interrupts
> +
> +additionalProperties: false
> +
> +allOf:

If there is going to be new version/resend, allOf: block goes before
additionalProperties:.

> +  - $ref: /schemas/interrupt-controller.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - realtek,rtd1319-intc-iso
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 1

Why the second interrupt is optional? It's a SoC, the pins are not
configurable usually. Same question for other cases.

> +...

Best regards,
Krzysztof