Re: [PATCH v2 6/6] MIPS: mobileye: eyeq5: use OLB clocks controller

[Krzysztof Kozlowski]

On 27/12/2023 17:23, Théo Lebrun wrote:
> We add the clock controller inside the OLB syscon region and removed
> previous fixed devicetree nodes representing PLLs exposed by the clock
> controller.
> 

...

>  / {
>  	#address-cells = <2>;
> @@ -42,6 +42,19 @@ soc: soc {
>  		ranges;
>  		compatible = "simple-bus";
>  
> +		olb: olb@e00000 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation


Often: system-controller

> +			compatible = "mobileye,eyeq5-olb", "syscon", "simple-mfd";
> +			reg = <0 0xe00000 0x0 0x400>;
> +			reg-io-width = <4>;
> +
> +			clocks: clock-controller {
> +				compatible = "mobileye,eyeq5-clk";
> +				#clock-cells = <1>;
> +				clocks = <&xtal>;
> +				clock-names = "ref";
> +			};
> +		};
> +


Best regards,
Krzysztof