Re: [PATCH 1/2] dt-bindings: iio: adc: rtq6056: add support for the whole RTQ6056 family

[ChiYuan Huang]

On Thu, Dec 28, 2023 at 11:26:04AM +0800, ChiYuan Huang wrote:
> On Tue, Dec 26, 2023 at 04:24:50PM +0000, Jonathan Cameron wrote:
> > On Tue, 26 Dec 2023 10:18:47 +0100
> > Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> > 
> > > On 26/12/2023 04:47, cy_huang@xxxxxxxxxxx wrote:
> > > > From: ChiYuan Huang <cy_huang@xxxxxxxxxxx>
> > > > 
> > > > Add compatible support for RTQ6053 and RTQ6059.
> > > > 
> > > > Signed-off-by: ChiYuan Huang <cy_huang@xxxxxxxxxxx>
> > > > ---
> > > >  .../devicetree/bindings/iio/adc/richtek,rtq6056.yaml         | 5 ++++-
> > > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml b/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml
> > > > index 88e008629ea8..d1e1f36d1972 100644
> > > > --- a/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml
> > > > +++ b/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml
> > > > @@ -25,7 +25,10 @@ description: |
> > > >  
> > > >  properties:
> > > >    compatible:
> > > > -    const: richtek,rtq6056
> > > > +    enum:
> > > > +      - richtek,rtq6053
> > > > +      - richtek,rtq6056  
> > > 
> > > Aren't these devices compatible? Your driver change says they are, so
> > > express compatibility with list here (and oneOf).
> > 
> > I'm not seeing this thread on lore.kernel.org or in my local email. 
> > Perhaps something went wrong?
> > 
> I also cannot find the original message in lore.kernel.org.
> But I checked the to/cc list. Nothing is lost.
> 
> Still not sure what happened.
Ok, it seems the only difference is that I forget to add --thread in 
git format-patch. But not sure for that.
When I send v2 patch for the binding fix, I'll check it again.

Sorry for the inconvenience.
> 
> Best Regards,
> ChiYuan
> > Jonathan
> > 
> > 
> > > 
> > > 
> > > Best regards,
> > > Krzysztof
> > > 
> >