Re: [PATCH 03/11] firmware: coreboot_table: Convert to platform remove callback returning void

From: Tzung-Bi Shih
Date: Wed Dec 27 2023 - 22:12:43 EST


On Wed, Dec 27, 2023 at 05:26:27PM +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> [...]

Applied, thanks!

[03/11] firmware: coreboot: Convert to platform remove callback returning void
commit: 09aeaabebdafbcf4afd1c481beaff37ecbc6b023