Re: [PATCH v2 1/2] arm64: dts: rockchip: support poweroff on the rock-5b

[Sebastian Reichel]

Hi,

On Mon, Dec 25, 2023 at 10:28:19PM +0000, John Clark wrote:
> Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now"
> on the rock-5b it reboots instead. Defining 'system-power-controller'
> allows the rk806 to power down.
> 
> Commit c699fbfdfd54 ("arm64: dts: rockchip: Support poweroff on
> NanoPC-T6") similarly resolves this issue for the nanopc-t6.
> 
> Signed-off-by: John Clark <inindev@xxxxxxxxx>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>

-- Sebastian

> Changes since v1:
>  - added commit message with additional patch detail
>  - expressed the related commit using checkpatch
> 
> ---
>  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> index 74719aaf697c..dc7b88f29172 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -426,6 +426,8 @@ pmic@0 {
>  		pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>,
>  			    <&rk806_dvs2_null>, <&rk806_dvs3_null>;
>  
> +		system-power-controller;
> +
>  		vcc1-supply = <&vcc5v0_sys>;
>  		vcc2-supply = <&vcc5v0_sys>;
>  		vcc3-supply = <&vcc5v0_sys>;
> -- 
> 2.43.0
> 
>

Attachment: signature.asc
Description: PGP signature