Re: [PATCH 01/10] clk: ti: Less function calls in of_omap2_apll_setup() after error detection

From: Andy Shevchenko
Date: Wed Dec 27 2023 - 11:39:07 EST


On Sun, Dec 24, 2023 at 05:36:57PM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sun, 24 Dec 2023 11:15:27 +0100
>
> The kfree() function was called in up to three cases by
> the of_omap2_apll_setup() function during error handling
> even if the passed variable contained a null pointer.
> This issue was detected by using the Coccinelle software.

> * Split a condition check.
>
> * Adjust jump targets.
>
> * Delete three initialisations which became unnecessary
> with this refactoring.

Instead, make use of cleanup.h.

--
With Best Regards,
Andy Shevchenko