Re: [PATCH 2/4] dt-bindings: mmc: add Marvell ac5

[Krzysztof Kozlowski]

On 27/12/2023 13:32, Elad Nachman wrote:
> From: Elad Nachman <enachman@xxxxxxxxxxx>
> 
> Add dt bindings for Marvell ac5 eMMC controller
> 
> Signed-off-by: Elad Nachman <enachman@xxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> index 3a8e74894ae0..50c6de8bf0bc 100644
> --- a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> @@ -34,6 +34,9 @@ properties:
>            - const: marvell,armada-3700-sdhci
>            - const: marvell,sdhci-xenon
>  
> +      - items:
> +          - const: marvell,ac5-sdhci

Please make earlier const as enum and add it there.

> +          - const: marvell,armada-ap806-sdhci

You also missed here blank line, but that won't matter after above change.


Best regards,
Krzysztof