Re: [PATCH v3 2/8] dt-bindings: marvell: a38x: add solidrun armada 385 clearfog gtr boards

From: Krzysztof Kozlowski
Date: Wed Dec 27 2023 - 06:50:26 EST


On 26/12/2023 19:11, Josua Mayer wrote:
> Add DT compatible for SolidRun Armada-385 based Clearfog GTR L8 and S4
> boards.
>
> Despite similar name these two boards are designed differently from the
> armada 388 clearfog base and pro, they only share a name and general use
> case.
>
> Signed-off-by: Josua Mayer <josua@xxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
> index 5af222e6db18..5bc69c4fe34d 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
> @@ -30,4 +30,12 @@ properties:
> - const: marvell,armada385
> - const: marvell,armada380
>
> + - description: SolidRun Armada 385 based single-board computers
> + items:
> + - enum:
> + - solidrun,clearfog-gtr-l8

When I pointed out in your previous versions that you do not test
patches, I did it in hope to encourage testing patches...

Standard boiler plate:

It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.

Best regards,
Krzysztof