Re: [PATCH v3 3/3] arm64: dts: mediatek: mt8195: Add 'rx-fifo-depth' for cherry

[Chunfeng Yun (云春峰)]

On Wed, 2023-12-20 at 11:30 +0100, AngeloGioacchino Del Regno wrote:
> Il 20/12/23 03:58, Chunfeng Yun ha scritto:
> > Add the quirk property "rx-fifo-depth" to work around Gen1 isoc-in
> > transfer issue which send out unexpected ACK even after device
> > already finished the burst transfer with a short patcket, specially
> > for a 4K camera device.
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx>
> > ---
> > v3: change value according to binding
> > v2: use 'rx-fifo-depth' property
> > ---
> >   arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> > index dd5b89b73190..58593348b810 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> > @@ -1185,6 +1185,7 @@
> >   
> 
> Can you please place rx-fifo-depth before power supplies?
Ok, thanks

> 
> after which,
> 
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@xxxxxxxxxxxxx>
> 
> Thanks,
> Angelo
> 
> >   	vusb33-supply = <&mt6359_vusb_ldo_reg>;
> >   	vbus-supply = <&usb_vbus>;
> > +	rx-fifo-depth = <3>;
> >   };
> >   
> >   &xhci1 {
> > @@ -1192,6 +1193,7 @@
> >   
> >   	vusb33-supply = <&mt6359_vusb_ldo_reg>;
> >   	vbus-supply = <&usb_vbus>;
> > +	rx-fifo-depth = <3>;
> >   };
> >   
> >   &xhci2 {
> 
>