Re: [PATCH v2] kdump: Remove redundant DEFAULT_CRASH_KERNEL_LOW_SIZE

[Baoquan He]

On 12/27/23 at 07:46am, Youling Tang wrote:
> From: Youling Tang <tangyouling@xxxxxxxxxx>
> 
> Remove duplicate definitions, no functional changes.
> 
> Reported-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>
> Signed-off-by: Youling Tang <tangyouling@xxxxxxxxxx>
> ---
>  include/linux/crash_core.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/linux/crash_core.h b/include/linux/crash_core.h
> index 5126a4fecb44..9eaeaafe0cad 100644
> --- a/include/linux/crash_core.h
> +++ b/include/linux/crash_core.h
> @@ -87,12 +87,6 @@ Elf_Word *append_elf_note(Elf_Word *buf, char *name, unsigned int type,
>  			  void *data, size_t data_len);
>  void final_note(Elf_Word *buf);
>  
> -#ifdef CONFIG_ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
> -#ifndef DEFAULT_CRASH_KERNEL_LOW_SIZE
> -#define DEFAULT_CRASH_KERNEL_LOW_SIZE  (128UL << 20)
> -#endif
> -#endif

Good catch, thx.

Acked-by: Baoquan He <bhe@xxxxxxxxxx>

> -
>  int __init parse_crashkernel(char *cmdline, unsigned long long system_ram,
>  		unsigned long long *crash_size, unsigned long long *crash_base,
>  		unsigned long long *low_size, bool *high);
> -- 
> 2.40.0
>