Re: [PATCH v6 2/2] lib/string: shrink lib/string.i via IWYU

From: Tanzir Hasan
Date: Tue Dec 26 2023 - 13:47:32 EST


On Tue, Dec 26, 2023 at 10:35 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Tue, Dec 26, 2023 at 8:00 PM Tanzir Hasan <tanzirh@xxxxxxxxxx> wrote:
> >
> > This diff uses an open source tool include-what-you-use (IWYU) to modify
> > the include list, changing indirect includes to direct includes. IWYU is
> > implemented using the IWYUScripts github repository which is a tool that
> > is currently undergoing development. These changes seek to improve build
> > times.
> >
> > This change to lib/string.c resulted in a preprocessed size of
> > lib/string.i from 26371 lines to 5321 lines (-80%) for the x86
> > defconfig.
>
> Why did you ignore my tag?

I'm sorry. I forgot you had already reviewed this one. In a future
revision I will include this:
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

Best,
Tanzir