Re: [RFC 16/16] riscv: dts: starfive: jh8100: Add clocks and resets nodes

From: Krzysztof Kozlowski
Date: Tue Dec 26 2023 - 08:39:03 EST


On 26/12/2023 06:38, Sia Jee Heng wrote:
> Add SYSCRG/SYSCRG-NE/SYSCRG-NW/SYSCRG-SW/AONCRG clock and reset
> nodes for JH8100 RISC-V SoC.
>
> Signed-off-by: Sia Jee Heng <jeeheng.sia@xxxxxxxxxxxxxxxx>
> Reviewed-by: Ley Foon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>
> ---

...

> compatible = "simple-bus";
> interrupt-parent = <&plic>;
> @@ -357,6 +563,99 @@ uart4: serial@121a0000 {
> status = "disabled";
> };
>
> + necrg: necrg@12320000 {

This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.

Best regards,
Krzysztof