Re: [PATCH v3 2/2] arm64: dts: imx93-var-som: Add Variscite VAR-SOM-MX93

From: Fabio Estevam
Date: Tue Dec 26 2023 - 08:24:52 EST


On Sun, Dec 24, 2023 at 9:41 AM Mathieu Othacehe <othacehe@xxxxxxx> wrote:

> +/{
> + model = "Variscite VAR-SOM-MX93 on Symphony evaluation board";
> + compatible = "variscite,var-som-mx93-symphony",
> + "variscite,var-som-mx93", "fsl,imx93";
> +
> + aliases {
> + ethernet1 = &fec;

You could pass ethernet0 here as well.


> +&lpi2c1 {
> + #address-cells = <1>;
> + #size-cells = <0>;

These are present in imx93.dtsi. You can drop them from here.

> +&lpi2c5 {
> + #address-cells = <1>;
> + #size-cells = <0>;

Ditto.

Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>